As a general rule is in clear water I prefer more natural colors, something that emulates shad, baitfish, crayfish, etc. so black, browns, greens, whites.
In murky water I use brigher colors: Chartruese, Orange, yellow, chrome,
For the most part I try to match the bait color to the natural forage. So if I'm fishing a tube its typically green or brown, or the clear/whitish color.
Worms, are mostly black or brown
Crankbaits, black, white, silver, green, maybe a little orange
Spinnerbaits, my best luck has been with black with a green tale. No idea why.
My buddy that fishes a lot of tournaments said his favorite color is Pumpkinseed.